Issue 10307003: Update locale char when moving position in number parsing in the JSON parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10307003: Update locale char when moving position in number parsing in the JSON parser. (Closed)

Created:
8 years, 7 months ago by Anders Johnsen

Modified:
8 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update locale char when moving position in number parsing in the JSON parser. BUG=http://code.google.com/p/dart/issues/detail?id=2858 TEST= Committed: https://code.google.com/p/dart/source/detail?r=7219

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added test cases. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -1 line)			Patch
	M	lib/json/json.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/utils/json_test.dart	View	1	2 chunks	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM https://chromiumcodereview.appspot.com/10307003/diff/1/tests/utils/json_test.dart File tests/utils/json_test.dart (right): https://chromiumcodereview.appspot.com/10307003/diff/1/tests/utils/json_test.dart#newcode21 tests/utils/json_test.dart:21: Expect.equals(1.0E-06, JSON.parse(' 1.0E-06 ')); More tests. How about ...

8 years, 7 months ago (2012-05-02 08:54:45 UTC) #3

Anders Johnsen

8 years, 7 months ago (2012-05-02 09:05:46 UTC) #4

Committing!

https://chromiumcodereview.appspot.com/10307003/diff/1/tests/utils/json_test....
File tests/utils/json_test.dart (right):

https://chromiumcodereview.appspot.com/10307003/diff/1/tests/utils/json_test....
tests/utils/json_test.dart:21: Expect.equals(1.0E-06, JSON.parse(' 1.0E-06 '));
On 2012/05/02 08:54:45, Lasse Reichstein Nielsen wrote:
> More tests. How about at least:
>  1E0
>  1E+0
>  1E-0
>  1E00
>  1E+00
>  1E-00
>  1E+10
>  1E+010   // Two digits to check that it's not octal.
>  1E+0010
>  1E10
>  1E010
>  1E0010
>  1E-10
>  1E-0010
> (and with lower-case 'e' too)
> And, in the failing part:
>  1E--6
>  1E-+6
>  1E+-6
>  1E++6
>  1E6.6
>  1E-6.6
>  1E+6.6
> 

Thank you! Added!

Expand Messages | Collapse Messages