Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10291006: Rename getTEMPNAME to get (Closed)

Created:
8 years, 7 months ago by vsm
Modified:
8 years, 7 months ago
Reviewers:
Bob Nystrom, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename getTEMPNAME to get BUG=2584 TEST=xhr_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7212

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -24 lines) Patch
M lib/dartdoc/client-live-nav.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/src/_XMLHttpRequestUtils.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/dom/templates/html/dartium/factoryprovider_XMLHttpRequest.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/dom/templates/html/frog/factoryprovider_XMLHttpRequest.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/dom/templates/html/interface/interface_XMLHttpRequest.darttemplate View 1 chunk +1 line, -1 line 1 comment Download
M lib/html/dartium/html_dartium.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/html/frog/html_frog.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/html/src/XMLHttpRequestWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M utils/apidoc/mdn/extract.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
8 years, 7 months ago (2012-05-01 23:04:13 UTC) #1
Jacob
lgtm
8 years, 7 months ago (2012-05-01 23:07:14 UTC) #2
Bob Nystrom
8 years, 7 months ago (2012-05-02 17:44:36 UTC) #3
LGTM, a thing of beauty!

https://chromiumcodereview.appspot.com/10291006/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/interface/interface_XMLHttpRequest.darttemplate
(right):

https://chromiumcodereview.appspot.com/10291006/diff/1/lib/dom/templates/html...
lib/dom/templates/html/interface/interface_XMLHttpRequest.darttemplate:10: //
not correctly implemented yet. (b/4970173)
Remove this comment.

Powered by Google App Engine
This is Rietveld 408576698