Issue 10280003: Set up a variable so that the compiler script can be imported using an import map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10280003: Set up a variable so that the compiler script can be imported using an import map. (Closed)

Created:
8 years, 7 months ago by siva

Modified:
8 years, 7 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Set up a variable so that the compiler script can be imported using an import map. Committed: https://code.google.com/p/dart/source/detail?r=7208

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -12 lines)			Patch
M	bin/run_vm_tests.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	vm/benchmark_test.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	vm/benchmark_test.cc	View	1	5 chunks	+48 lines, -6 lines	0 comments	Download
M	vm/unit_test.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	vm/unit_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

lgtm http://codereview.chromium.org/10280003/diff/1/vm/benchmark_test.cc File vm/benchmark_test.cc (right): http://codereview.chromium.org/10280003/diff/1/vm/benchmark_test.cc#newcode196 vm/benchmark_test.cc:196: char* ptr = strrchr(dart2js_path, File::PathSeparatorCharacter()); Why not assert ...

8 years, 7 months ago (2012-05-01 21:41:52 UTC) #2

siva

8 years, 7 months ago (2012-05-01 22:02:49 UTC) #3

http://codereview.chromium.org/10280003/diff/1/vm/benchmark_test.cc
File vm/benchmark_test.cc (right):

http://codereview.chromium.org/10280003/diff/1/vm/benchmark_test.cc#newcode196
vm/benchmark_test.cc:196: char* ptr = strrchr(dart2js_path,
File::PathSeparatorCharacter());
On 2012/05/01 21:41:52, cshapiro wrote:
> Why not assert that the path separator is 1 character long and use
> *File::PathSeparator() instead.  This eliminates the need for the new
function.

Done.

http://codereview.chromium.org/10280003/diff/1/vm/benchmark_test.cc#newcode207
vm/benchmark_test.cc:207: ptr = strrchr(dart2js_path,
File::PathSeparatorCharacter());
On 2012/05/01 21:41:52, cshapiro wrote:
> Same here.

Done.

Expand Messages | Collapse Messages

Issue 10280003: Set up a variable so that the compiler script can be imported using an import map. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages