Issue 10272031: Merge two functions that create sideffect free compound load nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10272031: Merge two functions that create sideffect free compound load nodes. (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Merge two functions that create side effect free compound load nodes. Committed: https://code.google.com/p/dart/source/detail?r=7201

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -87 lines)			Patch
	M	runtime/vm/parser.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/parser.cc	View	1	4 chunks	+55 lines, -86 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hausner

8 years, 7 months ago (2012-05-01 18:40:40 UTC) #2

LGTM. The code is still a bit confusing in that "left" and "right" expressions
are difficult to understand, but you did not make it worse, so you're good to
go.

Expand Messages | Collapse Messages