Issue 10270010: Remove getType; use the resolver instead.

Issue 10270010: Remove getType; use the resolver instead. (Closed)

Created:
8 years, 7 months ago by karlklose

Modified:
8 years, 7 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove getType; use the resolver instead. Committed: https://code.google.com/p/dart/source/detail?r=7250

Patch Set 2 : Address comments. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -47 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	3 chunks	+2 lines, -44 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	2 chunks	+20 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/typechecker.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! Very nice. Cheers, Peter http://codereview.chromium.org/10270010/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): http://codereview.chromium.org/10270010/diff/1/lib/compiler/implementation/compiler.dart#newcode414 lib/compiler/implementation/compiler.dart:414: Type resolveType(Element element, TypeAnnotation ...

8 years, 7 months ago (2012-05-02 14:15:53 UTC) #3

karlklose

8 years, 7 months ago (2012-05-02 18:43:54 UTC) #4

Thank you, Nicolas and Peter.

http://codereview.chromium.org/10270010/diff/1/lib/compiler/implementation/co...
File lib/compiler/implementation/compiler.dart (right):

http://codereview.chromium.org/10270010/diff/1/lib/compiler/implementation/co...
lib/compiler/implementation/compiler.dart:414: Type resolveType(Element element,
TypeAnnotation annotation) {
On 2012/05/02 14:15:53, ahe wrote:
> resolveTypeAnnotation?

Done.

http://codereview.chromium.org/10270010/diff/1/lib/compiler/implementation/co...
lib/compiler/implementation/compiler.dart:415: return
resolver.resolveType(element, annotation);
On 2012/05/02 14:15:53, ahe wrote:
> Ditto

Done.

Expand Messages | Collapse Messages