Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 10269025: Update SDK with VM native extension development files. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update SDK with VM native extension development files. - dart_api.h - import library on Windows - dart_debugger_api.h The debugger api is not necessarily needed at this point but I see no reason to leave it out. Dan, do I need to do something more than this to make sure that the import library that is only built on Windows ends up in the final SDK that we ship? R=dgrove@google.com,whesse@google.com,iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=7182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M tools/create_sdk.py View 4 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 7 months ago (2012-05-01 07:34:53 UTC) #1
Bill Hesse
Looks correct to me. I will let Dan approve it, though.
8 years, 7 months ago (2012-05-01 08:07:27 UTC) #2
Ivan Posva
LGTM -ip
8 years, 7 months ago (2012-05-01 08:51:00 UTC) #3
dgrove
8 years, 7 months ago (2012-05-01 09:14:09 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698