Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 10265027: Move all the builtin$ interceptors to a new interceptors library and shorten the names of them. (Closed)

Created:
8 years, 7 months ago by kasperl
Modified:
8 years, 7 months ago
Reviewers:
floitsch, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move all the builtin$ interceptors to a new interceptors library and shorten the names of them. R=ngeoffray@google.com,floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7187

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove string interpolation. #

Patch Set 3 : Update doc. #

Patch Set 4 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+678 lines, -643 lines) Patch
M lib/compiler/implementation/compiler.dart View 3 chunks +14 lines, -6 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A lib/compiler/implementation/lib/interceptors.dart View 1 chunk +636 lines, -0 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 3 12 chunks +1 line, -631 lines 0 comments Download
M lib/compiler/implementation/library_map.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 2 3 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 7 months ago (2012-05-01 14:20:26 UTC) #1
floitsch
LGTM! https://chromiumcodereview.appspot.com/10265027/diff/1/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10265027/diff/1/lib/compiler/implementation/elements/elements.dart#newcode308 lib/compiler/implementation/elements/elements.dart:308: Element findLocal(SourceString elementName) { add /**doc*/ for [findLocal] ...
8 years, 7 months ago (2012-05-01 14:37:44 UTC) #2
ngeoffray
8 years, 7 months ago (2012-05-02 08:02:41 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698