Issue 10264031: Switch from AST node ids to computation ids (cid). In addition to computations,…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10264031: Switch from AST node ids to computation ids (cid). In addition to computations,… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Switch from AST node ids to computation ids (cid). In addition to computations, some instructions need it as well (Return, Throw, ReThrow). Currently added to all Instructions and Computations. Committed: https://code.google.com/p/dart/source/detail?r=7205

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -198 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 2 3	5 chunks	+3 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3	48 chunks	+41 lines, -79 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	23 chunks	+30 lines, -30 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	35 chunks	+47 lines, -73 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM Does it mean we can remove node ids from the ast once we remove ...

8 years, 7 months ago (2012-05-01 20:10:40 UTC) #2

srdjan

8 years, 7 months ago (2012-05-01 20:21:29 UTC) #3

On 2012/05/01 20:10:40, regis wrote:
> LGTM
> 
> Does it mean we can remove node ids from the ast once we remove the old code
> generator?

Yes, once we remove both old code generators.

Expand Messages | Collapse Messages