Add a space at the end of line being parsed to correctly process cases like 3.14.

Add a space at the end of line being parsed to correctly process cases like 3.14.

TBR=ajohnsen@google.com
BUG=2782
TEST=json_test.dart

Committed: https://code.google.com/p/dart/source/detail?r=7121

[Anders Johnsen, 2012-04-28 08:23:22]

https://chromiumcodereview.appspot.com/10257029/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10257029/diff/1/lib/json/json.dart#new...
lib/json/json.dart:99: _JsonParser._internal(String json) : this.json = '${json}
' {
This is not the correct way to fix this. This will re-allocate the string. I'll
fix my number parsing.

[Anton Muhin, 2012-04-28 08:25:07]

https://chromiumcodereview.appspot.com/10257029/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10257029/diff/1/lib/json/json.dart#new...
lib/json/json.dart:99: _JsonParser._internal(String json) : this.json = '${json}
' {
On 2012/04/28 08:23:22, ajohnsen wrote:
> This is not the correct way to fix this. This will re-allocate the string.
I'll
> fix my number parsing.

I didn't do performance measurements, I'd prefer it work correctly first.

Regarding number parsing code.  I was considering this as well, but it's not
obvious what is better in the long run: additional checks if the string is
exhausted or one additional allocation.

[Anders Johnsen, 2012-04-28 09:03:07]

LGTM

https://chromiumcodereview.appspot.com/10257029/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10257029/diff/1/lib/json/json.dart#new...
lib/json/json.dart:99: _JsonParser._internal(String json) : this.json = '${json}
' {
On 2012/04/28 08:25:07, antonmuhin wrote:
> On 2012/04/28 08:23:22, ajohnsen wrote:
> > This is not the correct way to fix this. This will re-allocate the string.
> I'll
> > fix my number parsing.
> 
> I didn't do performance measurements, I'd prefer it work correctly first.
> 
> Regarding number parsing code.  I was considering this as well, but it's not
> obvious what is better in the long run: additional checks if the string is
> exhausted or one additional allocation.

Agreed! I'll fix the number parsing error in another CL.