Issue 10257004: Turn dart2js into a shell script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10257004: Turn dart2js into a shell script. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Turn dart2js into a shell script. Committed: https://code.google.com/p/dart/source/detail?r=7083

Patch Set 2 : Address review comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -35 lines)			Patch
	M	dart/lib/compiler/implementation/dart2js.dart	View		2 chunks	+25 lines, -0 lines	0 comments	Download
	M	dart/utils/compiler/build_helper.dart	View	1	2 chunks	+12 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10257004/diff/1/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/10257004/diff/1/dart/utils/compiler/build_helper.dart#newcode68 dart/utils/compiler/build_helper.dart:68: String libraryRoot = relativize(dartVmLocation, dartUri); Is libraryRoot still ...

8 years, 8 months ago (2012-04-27 13:50:14 UTC) #2

ahe

Thank you, Kasper! https://chromiumcodereview.appspot.com/10257004/diff/1/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://chromiumcodereview.appspot.com/10257004/diff/1/dart/utils/compiler/build_helper.dart#newcode68 dart/utils/compiler/build_helper.dart:68: String libraryRoot = relativize(dartVmLocation, dartUri); On ...

8 years, 8 months ago (2012-04-27 14:40:12 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 10257004: Turn dart2js into a shell script. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments #

Messages