Issue 10255015: Handle an exception handler returning null more gracefully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10255015: Handle an exception handler returning null more gracefully. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom

Modified:
8 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle an exception handler returning null more gracefully. Committed: https://code.google.com/p/dart/source/detail?r=7109

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	corelib/src/implementation/future_implementation.dart	View		4 chunks	+10 lines, -8 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 8 months ago (2012-04-27 22:32:51 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10255015/diff/1/corelib/src/implementa...
File corelib/src/implementation/future_implementation.dart (right):

https://chromiumcodereview.appspot.com/10255015/diff/1/corelib/src/implementa...
corelib/src/implementation/future_implementation.dart:22: bool _exceptionHandled
= false;
yay!

https://chromiumcodereview.appspot.com/10255015/diff/1/corelib/src/implementa...
corelib/src/implementation/future_implementation.dart:94: // Explicitly check
for true here so that if the handler returns null,
booo! :(

Expand Messages | Collapse Messages