Issue 10255002: Fix WebSocket header construction for large frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10255002: Fix WebSocket header construction for large frames. (Closed)

Created:
8 years, 8 months ago by Anders Johnsen

Modified:
8 years, 8 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix WebSocket header construction for large frames. The spec uses 8 bytes for length if it's larger then 65535. This was only done when appending data to the header, not when setting the header size. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7062

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/bin/websocket_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 8 months ago (2012-04-27 09:21:01 UTC) #2

LGTM, we should consider introducing named constants though.

Expand Messages | Collapse Messages