Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 10254001: Add websocket files to dummy io.dart implementation for dart2js. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)
Modified:
8 years, 8 months ago
Reviewers:
Bob Nystrom, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add websocket files to dummy io.dart implementation for dart2js. Apparently this file is also used for generating API documentation now. We need to move away from that and generate the API documentation from the io_runtime.dart file in the SDK. The dummy implementation file is not automatically updated and therefore this will keep breaking. R=ahe@google.com,rnystrom@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7063

Patch Set 1 #

Patch Set 2 : Fix code blocks #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M lib/compiler/implementation/lib/io.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/websocket.dart View 1 1 chunk +4 lines, -4 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 8 months ago (2012-04-27 07:52:16 UTC) #1
ahe
LGTM. FWIW, as long as dart-sdk/lib/io/io_runtime.dart sources in files that are not written in the ...
8 years, 8 months ago (2012-04-27 09:27:45 UTC) #2
Mads Ager (google)
https://chromiumcodereview.appspot.com/10254001/diff/3001/runtime/bin/websocket.dart File runtime/bin/websocket.dart (right): https://chromiumcodereview.appspot.com/10254001/diff/3001/runtime/bin/websocket.dart#newcode9 runtime/bin/websocket.dart:9: * WebSocketHandler wsHandler = new WebSocketHandler(); On 2012/04/27 09:27:45, ...
8 years, 8 months ago (2012-04-27 09:29:50 UTC) #3
Bob Nystrom
8 years, 8 months ago (2012-04-27 18:06:37 UTC) #4
FYI

https://chromiumcodereview.appspot.com/10254001/diff/3001/runtime/bin/websock...
File runtime/bin/websocket.dart (right):

https://chromiumcodereview.appspot.com/10254001/diff/3001/runtime/bin/websock...
runtime/bin/websocket.dart:9: *     WebSocketHandler wsHandler = new
WebSocketHandler();
On 2012/04/27 09:29:50, Mads Ager wrote:
> On 2012/04/27 09:27:45, ahe wrote:
> > Code samples should be wrapped in [:CODE_HERE:].
> 
> Yes, I know. But that will look horrible with the current version of dartdoc.
:(

I think what Mads is doing here is fine. The indentation defines a code block in
markdown. Unlike [: ... :], I think, this also unambiguously lets dartdoc know
that it should be a <pre> code block and not <code>.

Powered by Google App Engine
This is Rietveld 408576698