Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10253022: test rename overhaul: step 13 - samples (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

test rename overhaul: step 13 - samples Committed: https://code.google.com/p/dart/source/detail?r=7164

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -5489 lines) Patch
A + samples/tests/samples/chat/chat_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + samples/tests/samples/dartcombat/dartcombat_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/tests/samples/lib/layout/css.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/layout/grid_examples.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/layout/grid_layout_demo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/layout/grid_layout_demo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/layout/layout.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/layout/layout.scss View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/layout/layout_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
A + samples/tests/samples/lib/observable/abstract_observable_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/observable/change_event_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/observable/event_batch_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/observable/observable_list_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/observable/observable_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
A + samples/tests/samples/lib/observable/observable_value_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/tests/samples/lib/touch/touch_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/tests/samples/lib/util/util_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/tests/samples/lib/view/view_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + samples/tests/samples/proxy/mint_maker_fully_isolated_generated_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/tests/samples/proxy/mint_maker_fully_isolated_test_source.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/tests/samples/proxy/mint_maker_promise_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + samples/tests/samples/proxy/mint_maker_promise_with_stubs_generated_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/tests/samples/proxy/mint_maker_promise_with_stubs_test_source.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/tests/samples/proxy/mint_maker_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + samples/tests/samples/proxy/promise_based_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/tests/samples/proxy/promise_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/tests/samples/samples.status View 1 chunk +34 lines, -23 lines 0 comments Download
D samples/tests/samples/samples-leg.status View 1 chunk +0 lines, -15 lines 0 comments Download
D samples/tests/samples/src/chat/ChatServerTest.dart View 1 chunk +0 lines, -341 lines 0 comments Download
D samples/tests/samples/src/dartcombat/DartCombatTest.dart View 1 chunk +0 lines, -167 lines 0 comments Download
D samples/tests/samples/src/lib/layout/CSS.dart View 1 chunk +0 lines, -348 lines 0 comments Download
D samples/tests/samples/src/lib/layout/GridExamples.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D samples/tests/samples/src/lib/layout/GridLayoutDemo.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D samples/tests/samples/src/lib/layout/LayoutTest.dart View 1 chunk +0 lines, -190 lines 0 comments Download
D samples/tests/samples/src/lib/layout/grid_layout_demo.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/tests/samples/src/lib/layout/grid_layout_demo.html View 1 chunk +0 lines, -12 lines 0 comments Download
D samples/tests/samples/src/lib/layout/layout.css View 1 chunk +0 lines, -18 lines 0 comments Download
D samples/tests/samples/src/lib/layout/layout.scss View 1 chunk +0 lines, -316 lines 0 comments Download
D samples/tests/samples/src/lib/observable/AbstractObservableTests.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D samples/tests/samples/src/lib/observable/ChangeEventTests.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D samples/tests/samples/src/lib/observable/EventBatchTests.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D samples/tests/samples/src/lib/observable/ObservableListTests.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D samples/tests/samples/src/lib/observable/ObservableTest.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D samples/tests/samples/src/lib/observable/ObservableValueTests.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D samples/tests/samples/src/lib/touch/TouchTest.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D samples/tests/samples/src/lib/util/UtilTest.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D samples/tests/samples/src/lib/view/ViewTest.dart View 1 chunk +0 lines, -205 lines 0 comments Download
D samples/tests/samples/src/proxy/MintMakerFullyIsolated_generatedTest.dart View 1 chunk +0 lines, -514 lines 0 comments Download
D samples/tests/samples/src/proxy/MintMakerFullyIsolated_testSource.dart View 1 chunk +0 lines, -309 lines 0 comments Download
D samples/tests/samples/src/proxy/MintMakerPromiseTest.dart View 1 chunk +0 lines, -245 lines 0 comments Download
D samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_generatedTest.dart View 1 chunk +0 lines, -262 lines 0 comments Download
D samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D samples/tests/samples/src/proxy/MintMakerRpcTest.dart View 1 chunk +0 lines, -247 lines 0 comments Download
D samples/tests/samples/src/proxy/PromiseBasedTest.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D samples/tests/samples/src/proxy/PromiseTest.dart View 1 chunk +0 lines, -724 lines 0 comments Download
D samples/tests/samples/src/swarm/SwarmTest.dart View 1 chunk +0 lines, -156 lines 0 comments Download
D samples/tests/samples/src/total/TotalTest.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/src/total/total_test_lib.dart View 1 chunk +0 lines, -463 lines 0 comments Download
A + samples/tests/samples/swarm/swarm_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
D samples/tests/samples/test_config.dart View 1 chunk +0 lines, -18 lines 0 comments Download
A + samples/tests/samples/total/total_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + samples/tests/samples/total/total_test_lib.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/test.dart View 3 chunks +2 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-28 01:28:25 UTC) #1
Jennifer Messerly
LGTM
8 years, 8 months ago (2012-04-28 01:54:53 UTC) #2
Bob Nystrom
LGTM! https://chromiumcodereview.appspot.com/10253022/diff/1/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10253022/diff/1/tools/test.dart#newcode51 tools/test.dart:51: 'samples/tests/samples', Not for this patch, but I wonder ...
8 years, 7 months ago (2012-04-30 16:18:52 UTC) #3
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/10253022/diff/1/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10253022/diff/1/tools/test.dart#newcode51 tools/test.dart:51: 'samples/tests/samples', On 2012/04/30 16:18:52, Bob Nystrom wrote: > Not ...
8 years, 7 months ago (2012-04-30 16:33:02 UTC) #4
Emily Fortuna
8 years, 7 months ago (2012-04-30 17:20:51 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698