Issue 10252023: Supper Uint8Clamped in manually written factories.

Issue 10252023: Supper Uint8Clamped in manually written factories. (Closed)

Created:
8 years, 7 months ago by Anton Muhin

Modified:
8 years, 7 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Supper Uint8Clamped in manually written factories. R=podivilov@chromium.org BUG=2791 Committed: https://code.google.com/p/dart/source/detail?r=7247

Patch Set 2 : + tests #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -1 line)			Patch
M	lib/dom/src/native_FactoryProviders.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/dom/src/native_FactoryProvidersImplementation.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/dom/typed_arrays_1_test.dart	View	1	1 chunk	+20 lines, -0 lines	2 comments	Download
M	tests/dom/typed_arrays_2_test.dart	View	1	1 chunk	+67 lines, -1 line	0 comments	Download
M	tests/dom/typed_arrays_4_test.dart	View	1	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://chromiumcodereview.appspot.com/10252023/diff/4/tests/dom/typed_arrays_1_test.dart File tests/dom/typed_arrays_1_test.dart (right): https://chromiumcodereview.appspot.com/10252023/diff/4/tests/dom/typed_arrays_1_test.dart#newcode36 tests/dom/typed_arrays_1_test.dart:36: test('aliasiClampedTest', () { It would make more sense to ...

8 years, 7 months ago (2012-05-02 14:54:37 UTC) #3

Anton Muhin

8 years, 7 months ago (2012-05-02 14:56:32 UTC) #4

podivilov

8 years, 7 months ago (2012-05-02 17:02:16 UTC) #5

LGTM.

Please replace supper with support in issue description.

Expand Messages | Collapse Messages