Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10247004: test rename overhaul: step 6 - isolate tests (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org, kasperl, Bill Hesse
Visibility:
Public.

Description

test rename overhaul: step 6 - isolate tests Committed: https://code.google.com/p/dart/source/detail?r=7088

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1875 lines) Patch
A + tests/isolate/constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/count_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/cross_isolate_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 2 chunks +30 lines, -22 lines 0 comments Download
D tests/isolate/isolate-leg.status View 1 chunk +0 lines, -12 lines 0 comments Download
A + tests/isolate/isolate2_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/isolate3_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/isolate_complex_messages_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/isolate_import_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/isolate_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/mandel_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/message2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/mint_maker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/mixed2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/mixed_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/nested_spawn2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/nested_spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/port_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/request_reply_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/serialization_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/isolate/src/APIv2_computeThisScriptBrowserTest.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/isolate/src/APIv2_spawnFunctionNegativeTest.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/isolate/src/APIv2_spawnFunctionTest.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/isolate/src/APIv2_spawnUriChildIsolate.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/isolate/src/APIv2_spawnUriNegativeTest.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/isolate/src/APIv2_spawnUriTest.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/isolate/src/APIv2_unresolvedPortsNegativeTest.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/isolate/src/APIv2_unresolvedPortsTest.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/isolate/src/ConstructorTest.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/isolate/src/CountTest.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/isolate/src/CrossIsolateMessageTest.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D tests/isolate/src/Isolate2NegativeTest.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/isolate/src/Isolate3NegativeTest.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/isolate/src/IsolateComplexMessagesTest.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/isolate/src/IsolateImportNegativeTest.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/isolate/src/IsolateNegativeTest.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/isolate/src/MandelIsolateTest.dart View 1 chunk +0 lines, -152 lines 0 comments Download
D tests/isolate/src/Message2Test.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D tests/isolate/src/MessageTest.dart View 1 chunk +0 lines, -135 lines 0 comments Download
D tests/isolate/src/MintMakerTest.dart View 1 chunk +0 lines, -266 lines 0 comments Download
D tests/isolate/src/Mixed2Test.dart View 1 chunk +0 lines, -133 lines 0 comments Download
D tests/isolate/src/MixedTest.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/isolate/src/NestedSpawn2Test.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D tests/isolate/src/NestedSpawnTest.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/isolate/src/PortTest.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/isolate/src/RequestReplyTest.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/isolate/src/SerializationTest.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D tests/isolate/src/SpawnTest.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/isolate/src/StaticStateTest.dart View 1 chunk +0 lines, -48 lines 0 comments Download
A + tests/isolate/static_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/isolate/test_config.dart View 1 chunk +0 lines, -16 lines 0 comments Download
A + tests/isolate/v2_compute_this_script_browser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/isolate/v2_spawn_function_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/v2_spawn_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/v2_spawn_uri_child_isolate.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/isolate/v2_spawn_uri_negative_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/isolate/v2_spawn_uri_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/isolate/v2_unresolved_ports_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/v2_unresolved_ports_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.dart View 3 chunks +1 line, -3 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
just for testing I copied here some of the changes to test.dart that are in ...
8 years, 8 months ago (2012-04-27 00:54:29 UTC) #1
Bob Nystrom
LGTM! https://chromiumcodereview.appspot.com/10247004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10247004/diff/1/tools/testing/dart/test_suite.dart#newcode358 tools/testing/dart/test_suite.dart:358: // directoy "directory".
8 years, 8 months ago (2012-04-27 16:02:44 UTC) #2
Siggi Cherem (dart-lang)
thx https://chromiumcodereview.appspot.com/10247004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10247004/diff/1/tools/testing/dart/test_suite.dart#newcode358 tools/testing/dart/test_suite.dart:358: // directoy On 2012/04/27 16:02:44, Bob Nystrom wrote: ...
8 years, 8 months ago (2012-04-27 17:07:01 UTC) #3
Emily Fortuna
8 years, 8 months ago (2012-04-27 18:29:41 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698