Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 1024553002: Fix analyzer warning / bug: Iterable was treated as if it has sublist() (Closed)

Created:
5 years, 9 months ago by kustermann
Modified:
5 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protobuf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix analyzer warning / bug: Iterable was treated as if it has sublist() R=sgjesse@google.com Committed: https://github.com/dart-lang/protobuf/commit/5019064a65123a4a3f970d2f469e0fc4e0629cd2

Patch Set 1 #

Patch Set 2 : Use an Iterable instead of a real List in test cases #

Patch Set 3 : Added test for Iterable with less elements than `end-start` #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/protobuf/pb_list.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/pb_list_test.dart View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
This should fix redness on package bots due to analyzer warning. [It might also improve ...
5 years, 9 months ago (2015-03-19 15:56:37 UTC) #2
Søren Gjesse
lgtm
5 years, 9 months ago (2015-03-19 16:32:45 UTC) #3
kustermann
Added test - using Iterable as argument to `setRange` - using Iterable with less elements ...
5 years, 9 months ago (2015-03-23 11:18:24 UTC) #5
kustermann
5 years, 9 months ago (2015-03-23 12:02:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
5019064a65123a4a3f970d2f469e0fc4e0629cd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698