Issue 10243013: Simpler and better inlined type checks as discussed. Changed inline type test cache arrays to conta…

Issue 10243013: Simpler and better inlined type checks as discussed. Changed inline type test cache arrays to conta… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simpler and better inlined type checks as discussed. Changed inline type test cache arrays to contain instance class, instance type argument and instantiator type argument (not yet used). Committed: https://code.google.com/p/dart/source/detail?r=7113

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -116 lines)			Patch
M	runtime/vm/code_generator.h	View	1 2 3 4	1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3 4	5 chunks	+48 lines, -42 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View		3 chunks	+24 lines, -73 lines	0 comments	Download
M	runtime/vm/stub_code.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4	1 chunk	+65 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

The old inlined code for testing subtype test cache will be moved to a stub ...

8 years, 8 months ago (2012-04-27 22:47:48 UTC) #1

regis

LGTM https://chromiumcodereview.appspot.com/10243013/diff/1010/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10243013/diff/1010/runtime/vm/code_generator.cc#newcode372 runtime/vm/code_generator.cc:372: // This updates the type test cache, an ...

8 years, 8 months ago (2012-04-27 23:27:47 UTC) #2

srdjan

8 years, 8 months ago (2012-04-27 23:43:19 UTC) #3

https://chromiumcodereview.appspot.com/10243013/diff/1010/runtime/vm/code_gen...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10243013/diff/1010/runtime/vm/code_gen...
runtime/vm/code_generator.cc:372: // This updates the type test cache, an array
containing tuples (instance class,
On 2012/04/27 23:27:48, regis wrote:
> The tuple contains 4 entries, right?

Done.

https://chromiumcodereview.appspot.com/10243013/diff/1010/runtime/vm/code_gen...
File runtime/vm/code_generator.h (right):

https://chromiumcodereview.appspot.com/10243013/diff/1010/runtime/vm/code_gen...
runtime/vm/code_generator.h:133: kInstantiatorArguments = 2,
On 2012/04/27 23:27:48, regis wrote:
> Is kInstantiatorTypeArguments too long? That would be a more accurate
> description.

renamed to kInstantiatorTypeArguments

Expand Messages | Collapse Messages