Issue 10243001: Support cyclic types and F-bounded quantification (issue 439).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10243001: Support cyclic types and F-bounded quantification (issue 439). (Closed)

Created:
8 years, 8 months ago by regis

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support cyclic types and F-bounded quantification (issue 439). Added tests for F-bounded quantification. Committed: https://code.google.com/p/dart/source/detail?r=7047

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -31 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	3 chunks	+35 lines, -17 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	tests/language/src/FBoundedQuantificationTest.dart	View	1	1 chunk	+36 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10243001/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://chromiumcodereview.appspot.com/10243001/diff/1/runtime/vm/class_finalizer.cc#newcode525 runtime/vm/class_finalizer.cc:525: // we must avoid the fractal of death. ...

8 years, 8 months ago (2012-04-26 22:30:21 UTC) #2

regis

8 years, 8 months ago (2012-04-26 22:39:04 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10243001/diff/1/runtime/vm/class_final...
File runtime/vm/class_finalizer.cc (right):

https://chromiumcodereview.appspot.com/10243001/diff/1/runtime/vm/class_final...
runtime/vm/class_finalizer.cc:525: // we must avoid the fractal of death. We
therefore map the inner most
On 2012/04/26 22:30:21, srdjan wrote:
> Need a link to 'fractal of death'  description ;-)
> 

Renamed "fractal of death" to "endless recursion".

> Also "innermost"
Done.

Expand Messages | Collapse Messages

Issue 10243001: Support cyclic types and F-bounded quantification (issue 439). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages