Issue 10239010: Make test.dart respect the requested order of test suites, and also split up IE

Issue 10239010: Make test.dart respect the requested order of test suites, and also split up IE (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 8 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang), sra1

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make test.dart respect the requested order of test suites, and also split up IE bot load. Committed: https://code.google.com/p/dart/source/detail?r=7035

Patch Set 2 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -59 lines)			Patch
	M	frog/scripts/buildbot_annotated_steps.py	View		8 chunks	+19 lines, -8 lines	0 comments	Download
	M	tools/test.dart	View	1	1 chunk	+37 lines, -51 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This change is to help our bots fail sooner if there is going to be ...

8 years, 8 months ago (2012-04-26 17:42:09 UTC) #1

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/10239010/diff/4/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10239010/diff/4/tools/test.dart#newcode103 tools/test.dart:103: } here you could use '} else if (...) ...

8 years, 8 months ago (2012-04-26 17:46:53 UTC) #2

Emily Fortuna

PTAL https://chromiumcodereview.appspot.com/10239010/diff/4/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10239010/diff/4/tools/test.dart#newcode103 tools/test.dart:103: } On 2012/04/26 17:46:53, sigmund wrote: > here ...

8 years, 8 months ago (2012-04-26 18:09:11 UTC) #3

Bill Hesse

https://chromiumcodereview.appspot.com/10239010/diff/6001/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10239010/diff/6001/tools/test.dart#newcode115 tools/test.dart:115: } else if (key == 'utils') { Surely this ...

8 years, 8 months ago (2012-04-26 21:56:33 UTC) #5

Emily Fortuna

8 years, 8 months ago (2012-04-26 22:02:47 UTC) #6

https://chromiumcodereview.appspot.com/10239010/diff/6001/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10239010/diff/6001/tools/test.dart#new...
tools/test.dart:115: } else if (key == 'utils') {
On 2012/04/26 21:56:33, Bill Hesse wrote:
> Surely this would be better as a switch statement, wouldn't it?

True again. I'll make the change.

Expand Messages | Collapse Messages