Issue 10239005: Add 'lib' test suite to default tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10239005: Add 'lib' test suite to default tests. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)

Modified:
8 years, 8 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add 'lib' test suite to default tests. R=ricow@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7014

Patch Set 2 : Address comment. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/testing/dart/test_options.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://chromiumcodereview.appspot.com/10239005/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://chromiumcodereview.appspot.com/10239005/diff/1/tools/testing/dart/test_options.dart#newcode13 tools/testing/dart/test_options.dart:13: 'isolate', 'vm', 'client', 'dartdoc', 'utils', 'pub', 'lib' ]; ...

8 years, 8 months ago (2012-04-26 12:36:45 UTC) #2

Mads Ager (google)

8 years, 8 months ago (2012-04-26 12:38:04 UTC) #3

https://chromiumcodereview.appspot.com/10239005/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_options.dart (right):

https://chromiumcodereview.appspot.com/10239005/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_options.dart:13: 'isolate', 'vm', 'client', 'dartdoc',
'utils', 'pub', 'lib' ];
On 2012/04/26 12:36:45, ricow1 wrote:
> there is an extra space after the '

Done.

Expand Messages | Collapse Messages

Issue 10239005: Add 'lib' test suite to default tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages