Issue 10238003: Reapply "Avoid "=== true" inside code by calling a function that does this for us."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10238003: Reapply "Avoid "=== true" inside code by calling a function that does this for us." (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Reapply "Avoid "=== true" inside code by calling a function that does this for us." This reapplies a fixed version of commit 7000. Original CL: https://chromiumcodereview.appspot.com//10140027 Committed: https://code.google.com/p/dart/source/detail?r=7013

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+250 lines, -24 lines)			Patch
A	frog/tests/leg/src/BoolifiedOperatorTest.dart	View	1 chunk	+74 lines, -0 lines	0 comments	Download
M	frog/tests/leg/src/ConstantFoldingTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/tests/leg/src/mock_compiler.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/js_helper.dart	View	8 chunks	+14 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1 chunk	+9 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	4 chunks	+24 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	4 chunks	+56 lines, -7 lines	0 comments	Download
A	tests/language/src/Operator5Test.dart	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	tests/utils/src/DummyCompilerTest.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM