Issue 10238002: Update test expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10238002: Update test expectations (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, floitsch, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update test expectations Disable new dart:io tests where they don't run. TBR=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7001

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/standalone/standalone.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/standalone/standalone-leg.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/10238002/diff/1/tests/standalone/standalone-leg.status File tests/standalone/standalone-leg.status (right): https://chromiumcodereview.appspot.com/10238002/diff/1/tests/standalone/standalone-leg.status#newcode17 tests/standalone/standalone-leg.status:17: crypto/Sha1Test.dart I think this should be: crypto/Sha1Test: Fail This ...

8 years, 7 months ago (2012-04-26 11:07:43 UTC) #2

Mads Ager (google)

8 years, 7 months ago (2012-04-26 11:25:32 UTC) #3

On 2012/04/26 11:07:43, ahe wrote:
>
https://chromiumcodereview.appspot.com/10238002/diff/1/tests/standalone/stand...
> File tests/standalone/standalone-leg.status (right):
> 
>
https://chromiumcodereview.appspot.com/10238002/diff/1/tests/standalone/stand...
> tests/standalone/standalone-leg.status:17: crypto/Sha1Test.dart
> I think this should be:
> 
> crypto/Sha1Test: Fail
> 
> This is actually not OK to fail. Florian is looking into why it is failing.

It is failing because of: dartbug.com/2725.

Expand Messages | Collapse Messages