Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 10236009: Add the most useful Apache Commons utils (Closed)

Created:
8 years, 8 months ago by scheglov
Modified:
8 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add the most useful Apache Commons utils R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7049

Patch Set 1 #

Patch Set 2 : Add Dart copyright header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14374 lines, -37 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +1 line, -1 line 0 comments Download
D compiler/java/com/google/dart/compiler/util/StringUtils.java View 1 chunk +0 lines, -36 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/ArrayUtils.java View 1 1 chunk +5799 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/CharSequenceUtils.java View 1 1 chunk +204 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/CharUtils.java View 1 1 chunk +546 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/LICENSE.txt View 1 chunk +202 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/NOTICE.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/ObjectUtils.java View 1 1 chunk +615 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/StringUtils.java View 1 1 chunk +6589 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/exception/CloneFailedException.java View 1 1 chunk +69 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/mutable/Mutable.java View 1 1 chunk +61 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/util/apache/mutable/MutableInt.java View 1 1 chunk +280 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 8 months ago (2012-04-26 18:12:50 UTC) #1
Brian Wilkerson
LGTM, except that, if I understood the conversation in the stand-up correctly, we want to ...
8 years, 8 months ago (2012-04-26 20:00:18 UTC) #2
scheglov
8 years, 8 months ago (2012-04-26 20:33:17 UTC) #3
On 2012/04/26 20:00:18, Brian Wilkerson wrote:
> LGTM, except that, if I understood the conversation in the stand-up correctly,
> we want to replace the file header with the same one used in the rest of the
> compiler code.

We can not _replace_ copyright header.
According to Apache License "4.Redistribution.(c)"
"      (c) You must retain, in the Source form of any Derivative Works
          that You distribute, all copyright, patent, trademark, and
          attribution notices from the Source form of the Work,
          excluding those notices that do not pertain to any part of
          the Derivative Works; and"

So, I've added Dart copyright header, but keep also previous Apache header.

Powered by Google App Engine
This is Rietveld 408576698