Fix small problems with precedence of cascades.

Fix small problems with precedence of cascades.

Conditional expressions didn't require their branches to be
expressionWithoutCascade.
Assignments didn't bind correctly relative to cascades. Added a flag
to be able to handle them both as expression and expressionWithoutCascade.

Committed: https://code.google.com/p/dart/source/detail?r=7055

[ahe, 2012-04-26 14:33:30]

https://chromiumcodereview.appspot.com/10236005/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10236005/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/parser.dart:12: bool mayParseCascades =
true;
Does this need to be a global flag?

[Lasse Reichstein Nielsen, 2012-04-27 07:08:31]

https://chromiumcodereview.appspot.com/10236005/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10236005/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/parser.dart:12: bool mayParseCascades =
true;
Actually not. Passing it to just parsePrecedenceExpression and
parseUnaryExpression is enough. I'll change to doing that.

https://chromiumcodereview.appspot.com/10236005/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/parser.dart:895: if (!mayParseCascades) {
Another alternative here is to start the outer for-loop with:
  if (level == CASCADE_PRECEDENCE && !mayParseCascades) continue;
It's probably slower than the current approach.

[ahe, 2012-05-01 15:50:50]

LGTM

https://chromiumcodereview.appspot.com/10236005/diff/4001/frog/tests/leg_only...
File frog/tests/leg_only/src/CascadePrecedenceTest.dart (right):

https://chromiumcodereview.appspot.com/10236005/diff/4001/frog/tests/leg_only...
frog/tests/leg_only/src/CascadePrecedenceTest.dart:55: //
    logicalOrExpression ('?' expressionWithoutCascade ':'
expressionWithoutCascade)?
Long line.

https://chromiumcodereview.appspot.com/10236005/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10236005/diff/4001/lib/compiler/implem...
lib/compiler/implementation/scanner/parser.dart:879: [bool withoutCascades]) {
No optional parameters please. This code is extremely hot :-)

https://chromiumcodereview.appspot.com/10236005/diff/4001/lib/compiler/implem...
lib/compiler/implementation/scanner/parser.dart:882: token =
parseUnaryExpression(token, withoutCascades);
It seems clearer too me if this parameter is named allowCascades. WDYT?

[ahe, 2012-09-24 16:49:01]

https://chromiumcodereview.appspot.com/10236005/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10236005/diff/4001/lib/compiler/implem...
lib/compiler/implementation/scanner/parser.dart:879: [bool withoutCascades]) {
Why was this submitted without addressing my comments?

[Lasse Reichstein Nielsen, 2012-09-24 17:58:09]

https://codereview.chromium.org/10236005/diff/4001/lib/compiler/implementatio...
File lib/compiler/implementation/scanner/parser.dart (right):

https://codereview.chromium.org/10236005/diff/4001/lib/compiler/implementatio...
lib/compiler/implementation/scanner/parser.dart:879: [bool withoutCascades]) {
A really good question. I vaguely remember actually doing the rename. Don't know
how it got lost again.
Will fix.