Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 10235011: Suppress crypto tests. (Closed)

Created:
8 years, 8 months ago by Anton Muhin
Modified:
8 years, 8 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Suppress crypto tests. Committed: https://code.google.com/p/dart/source/detail?r=7038

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
TBRing
8 years, 8 months ago (2012-04-26 19:45:56 UTC) #1
srdjan
https://chromiumcodereview.appspot.com/10235011/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://chromiumcodereview.appspot.com/10235011/diff/1/tests/lib/lib.status#newcode16 tests/lib/lib.status:16: crypto/*: Skip # Don't run tests using crypto in ...
8 years, 8 months ago (2012-04-26 21:52:41 UTC) #2
Ivan Posva
LGTM, but instead of stating the obvious (skipping tests in browser), can you please explain ...
8 years, 8 months ago (2012-04-27 05:06:44 UTC) #3
Anton Muhin
Srdjan, it doesn't timeout, but it fails to load as #import is not from the ...
8 years, 8 months ago (2012-04-27 12:54:48 UTC) #4
Anton Muhin
8 years, 8 months ago (2012-04-27 12:55:11 UTC) #5
Sorry, Ivan, will do, just wanted to fix redness on bbs asap.

On 2012/04/27 12:54:48, antonmuhin wrote:
> Srdjan, it doesn't timeout, but it fails to load as #import is not from the
lib
> in our infrastructure, see http://code.google.com/p/dart/issues/detail?id=2264
> 
> However, I just saw the imports fail and suppressed the tests.
> 
> On 2012/04/26 21:52:41, srdjan wrote:
> > https://chromiumcodereview.appspot.com/10235011/diff/1/tests/lib/lib.status
> > File tests/lib/lib.status (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10235011/diff/1/tests/lib/lib.status#n...
> > tests/lib/lib.status:16: crypto/*: Skip # Don't run tests using crypto in
the
> > browser
> > The benchmarks seem pretty quick in release mode, why not suppress them in
> debug
> > mode only?

Powered by Google App Engine
This is Rietveld 408576698