Issue 10233007: Fix mistake in status file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10233007: Fix mistake in status file (Closed)

Created:
8 years, 8 months ago by Søren Gjesse

Modified:
8 years, 8 months ago

Reviewers:
Mads Ager (google), ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix mistake in status file TBR=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7005

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/standalone/standalone-leg.status	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10233007/diff/1/tests/standalone/standalone-leg.status File tests/standalone/standalone-leg.status (right): https://chromiumcodereview.appspot.com/10233007/diff/1/tests/standalone/standalone-leg.status#newcode17 tests/standalone/standalone-leg.status:17: crypto/Sha1Test: Skip Should that be Fail, OK?

8 years, 8 months ago (2012-04-26 11:08:42 UTC) #2

Søren Gjesse

8 years, 8 months ago (2012-04-26 11:16:30 UTC) #3

https://chromiumcodereview.appspot.com/10233007/diff/1/tests/standalone/stand...
File tests/standalone/standalone-leg.status (right):

https://chromiumcodereview.appspot.com/10233007/diff/1/tests/standalone/stand...
tests/standalone/standalone-leg.status:17: crypto/Sha1Test: Skip
On 2012/04/26 11:08:43, ngeoffray wrote:
> Should that be Fail, OK?

It is a temporary test which will go away when the implementation from
lib/crypto is added to the VM. So I thought we should just skip it.

Expand Messages | Collapse Messages