Check the state of the HTTP request and response when handling headers

Check the state of the HTTP request and response when handling headers

The HTTP headers object in request and response objects is now marked
as non-mutable when it cannot be changed. An exception will be thrown
if trying to mutate headers when they are not mutable.

Postponed the sending of the headers until either the first byte of
body data is sent or the empty body is indicated. This is to allow
getting the output stream object and still be able to set headers
until the actual body is touched.

Added checking of the number of bytes of body data transmitted when an
explicit content length is specified.

R=ajohnsen@google.com

BUG=none
TEST=tests/standalone/src/io/HttpHeadersState.dart,tests/standalone/src/io/HttpContentLengthTest.dart

Committed: https://code.google.com/p/dart/source/detail?r=7010

[Anders Johnsen, 2012-04-26 10:12:49]

LGTM!

https://chromiumcodereview.appspot.com/10232006/diff/3001/runtime/bin/http_im...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10232006/diff/3001/runtime/bin/http_im...
runtime/bin/http_impl.dart:333: _bodyBytesWritten += bytes;
The "check" method here is mutable. Should we rename it?

[Søren Gjesse, 2012-04-26 11:26:40]

https://chromiumcodereview.appspot.com/10232006/diff/3001/runtime/bin/http_im...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10232006/diff/3001/runtime/bin/http_im...
runtime/bin/http_impl.dart:333: _bodyBytesWritten += bytes;
On 2012/04/26 10:12:50, ajohnsen wrote:
> The "check" method here is mutable. Should we rename it?

Good point. Renamed to _updateContentLength.