Issue 10228010: Address perf regression by using the expected frame layout when traversing frames in the code gener…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10228010: Address perf regression by using the expected frame layout when traversing frames in the code gener… (Closed)

Created:
8 years, 8 months ago by siva

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address perf regression by using the expected frame layout when traversing frames in the code generator. This is a temporary fix until we have a cache to speed up LookupCode. Committed: https://code.google.com/p/dart/source/detail?r=6972

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -24 lines)			Patch
	M	runtime/vm/code_generator.cc	View	1	9 chunks	+33 lines, -24 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10228010/diff/3001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10228010/diff/3001/runtime/vm/code_generator.cc#newcode37 runtime/vm/code_generator.cc:37: StackFrameIterator* iterator, bool has_stub_frame) { You could move ...

8 years, 8 months ago (2012-04-25 19:31:13 UTC) #2

siva

8 years, 8 months ago (2012-04-25 20:08:49 UTC) #3

https://chromiumcodereview.appspot.com/10228010/diff/3001/runtime/vm/code_gen...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10228010/diff/3001/runtime/vm/code_gen...
runtime/vm/code_generator.cc:37: StackFrameIterator* iterator, bool
has_stub_frame) {
Not really because the caller_frame that is returned has state in the iterator
and if the iterator is destroyed then the state is lost.
If I move it here the iterator destructor will run as we return from this
function.

On 2012/04/25 19:31:13, srdjan wrote:
> You could move the StackFrameIterator in here, instead of passing it in.

Expand Messages | Collapse Messages