Issue 10228003: Address review comments from CL 10151014.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10228003: Address review comments from CL 10151014. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
Bill Hesse, kasperl

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Address review comments from CL 10151014. Committed: https://code.google.com/p/dart/source/detail?r=7016

Patch Set 3 : typos #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -14 lines)			Patch
	M	dart/lib/compiler/implementation/dart2js.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	dart/tools/testing/dart/test_suite.dart	View	1 2	6 chunks	+27 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://chromiumcodereview.appspot.com/10228003/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10228003/diff/1/dart/tools/testing/dart/test_suite.dart#newcode998 dart/tools/testing/dart/test_suite.dart:998: } else { Nice. Should you reach out ...

8 years, 8 months ago (2012-04-25 13:55:04 UTC) #2

ahe

8 years, 8 months ago (2012-04-25 14:00:33 UTC) #3

https://chromiumcodereview.appspot.com/10228003/diff/1/dart/tools/testing/dar...
File dart/tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10228003/diff/1/dart/tools/testing/dar...
dart/tools/testing/dart/test_suite.dart:998: } else {
On 2012/04/25 13:55:04, Bill Hesse wrote:
> Nice.  Should you reach out to other non-vm compilers to get them to join
> dart2js here?

Frog is EOL. I don't know about dartc.

Expand Messages | Collapse Messages

Issue 10228003: Address review comments from CL 10151014. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : typos #

Messages