Issue 10227006: (Redoing the change 6946) Progress toward inlined type checks for classes with type arguments: fact…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10227006: (Redoing the change 6946) Progress toward inlined type checks for classes with type arguments: fact… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

(Redoing the change 6946) Progress toward inlined type checks for classes with type arguments: factor out code, optimize type arguments of an instance. Committed: https://code.google.com/p/dart/source/detail?r=6975

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -157 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3	5 chunks	+151 lines, -112 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	6 chunks	+67 lines, -29 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	4 chunks	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10227006/diff/2003/runtime/vm/object.h File runtime/vm/object.h (right): https://chromiumcodereview.appspot.com/10227006/diff/2003/runtime/vm/object.h#newcode534 runtime/vm/object.h:534: static intptr_t type_arguments_instance_field_offset_offset() { Do you need this?

8 years, 8 months ago (2012-04-25 21:11:36 UTC) #2

srdjan

8 years, 8 months ago (2012-04-25 21:13:27 UTC) #3

https://chromiumcodereview.appspot.com/10227006/diff/2003/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/10227006/diff/2003/runtime/vm/object.h...
runtime/vm/object.h:534: static intptr_t
type_arguments_instance_field_offset_offset() {
On 2012/04/25 21:11:36, regis wrote:
> Do you need this?

Forgot to mention: this is needed by the following change containing assembly
code.

Expand Messages | Collapse Messages