Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 10226002: Remove the RequestHandler interface from the HTTP library (Closed)

Created:
8 years, 8 months ago by Søren Gjesse
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the RequestHandler interface from the HTTP library Having the RequestHandler interface did no add anything, so it has been removed. The HTTP server function addRequestHandler and setter defaultRequestHandler now just takes function. To use an instance of a class with a request handler member function the Dart auto closurerization works fine. R=ajohnsen@google.com, ager@google.com BUG=none TEST=tests/standalone/src/io/HttpServerHandlerTest.dart Committed: https://code.google.com/p/dart/source/detail?r=6939

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -43 lines) Patch
M runtime/bin/http.dart View 2 chunks +10 lines, -17 lines 0 comments Download
M runtime/bin/http_impl.dart View 4 chunks +8 lines, -21 lines 4 comments Download
M tests/standalone/src/io/HttpServerHandlerTest.dart View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
8 years, 8 months ago (2012-04-25 08:37:45 UTC) #1
Anders Johnsen
LGTM. I'm not sure on how exactly auto closurerization works in Dart, can we fast ...
8 years, 8 months ago (2012-04-25 08:46:23 UTC) #2
Søren Gjesse
https://chromiumcodereview.appspot.com/10226002/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/10226002/diff/1/runtime/bin/http_impl.dart#newcode871 runtime/bin/http_impl.dart:871: } catch (var e) { On 2012/04/25 08:46:23, ajohnsen ...
8 years, 8 months ago (2012-04-25 08:54:41 UTC) #3
Mads Ager (google)
8 years, 8 months ago (2012-04-25 09:57:31 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698