Issue 10223003: Restructure flow-graph translation of increment operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10223003: Restructure flow-graph translation of increment operations. (Closed)

Created:
8 years, 8 months ago by Kevin Millikin (Google)

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Restructure flow-graph translation of increment operations. Remove all explicitly named temporaries. Use the flow-graph builder visitors to track temporary indexes. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6991

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -98 lines)			Patch
	M	runtime/vm/flow_graph_builder.h	View		2 chunks	+16 lines, -14 lines	0 comments	Download
	M	runtime/vm/flow_graph_builder.cc	View		6 chunks	+153 lines, -84 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

In a future (but soon to come) change, the explicit calls to AllocateTempIndex and DeallocateTempIndex ...

8 years, 8 months ago (2012-04-25 14:11:07 UTC) #1

srdjan

8 years, 8 months ago (2012-04-25 23:38:19 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10223003/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10223003/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:801: new PickTempInstr(temp_index(),
load->temp_index());
What is the plan with Pick and Tuck instructions? One possibility is to allow
multiple uses, the other is to change AST not require them.

Expand Messages | Collapse Messages