Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10222026: Migrate dom tests to dart:html. (Closed)

Created:
8 years, 8 months ago by podivilov
Modified:
8 years, 8 months ago
Reviewers:
vsm, Anton Muhin, antonm, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 12

Patch Set 2 : Rebase & address comments. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -447 lines) Patch
M lib/dom/src/native_DOMPublic.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/dom/async_window_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/audiocontext_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/cache_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/callbacks_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/canvas_pixel_array_type_alias_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M tests/dom/canvas_test.dart View 1 1 chunk +8 lines, -8 lines 1 comment Download
M tests/dom/canvas_using_html_test.dart View 1 1 chunk +8 lines, -8 lines 1 comment Download
M tests/dom/cross_frame_test.dart View 1 1 chunk +7 lines, -10 lines 0 comments Download
M tests/dom/css_test.dart View 1 3 chunks +13 lines, -13 lines 0 comments Download
M tests/dom/dart_object_local_storage_test.dart View 1 3 chunks +7 lines, -7 lines 0 comments Download
M tests/dom/document_test.dart View 1 1 chunk +7 lines, -13 lines 0 comments Download
M tests/dom/dom.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/dom/dom_constructors_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/dom_isolates_test.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tests/dom/domparser_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/events_test.dart View 1 1 chunk +21 lines, -22 lines 0 comments Download
M tests/dom/exceptions_test.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tests/dom/history_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/htmlaudioelement_test.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M tests/dom/htmlcollection_test.dart View 1 12 chunks +74 lines, -74 lines 0 comments Download
M tests/dom/htmlelement_test.dart View 1 3 chunks +42 lines, -42 lines 0 comments Download
M tests/dom/indexeddb_1_test.dart View 1 7 chunks +19 lines, -21 lines 0 comments Download
M tests/dom/indexeddb_2_test.dart View 1 5 chunks +11 lines, -12 lines 0 comments Download
M tests/dom/indexeddb_3_test.dart View 1 7 chunks +12 lines, -12 lines 0 comments Download
M tests/dom/indexeddb_4_test.dart View 1 7 chunks +11 lines, -11 lines 0 comments Download
M tests/dom/inner_frame_test.dart View 1 4 chunks +10 lines, -10 lines 0 comments Download
M tests/dom/instance_of_test.dart View 1 3 chunks +19 lines, -19 lines 1 comment Download
M tests/dom/isolates_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/dom/key_name_location_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/messageevent_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/dom/native_gc_test.dart View 1 2 chunks +7 lines, -8 lines 0 comments Download
M tests/dom/performance_api_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/request_animation_frame_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/serialized_script_value_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/dom/storage_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/dom/svg_1_test.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M tests/dom/svg_2_test.dart View 1 3 chunks +7 lines, -7 lines 0 comments Download
M tests/dom/svg_3_test.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download
M tests/dom/typed_arrays_1_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/typed_arrays_2_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/typed_arrays_3_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/typed_arrays_4_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/typing_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/dom/webgl_1_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/dom/websocket_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/window_eq_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/dom/window_mangling_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/dom/window_nosuchmethod_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/dom/window_open_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tests/dom/wrapper_test.dart View 1 1 chunk +12 lines, -12 lines 1 comment Download
M tests/dom/xhr_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/dom/xsltprocessor_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
podivilov
8 years, 8 months ago (2012-04-26 18:24:01 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10222026/diff/1/client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart File client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart (right): https://chromiumcodereview.appspot.com/10222026/diff/1/client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart#newcode20 client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart:20: canvas.attributes['width'] = '$width'; do you need to stingify width/height ...
8 years, 8 months ago (2012-04-26 18:47:36 UTC) #2
Jacob
https://chromiumcodereview.appspot.com/10222026/diff/1/client/tests/client/dom/EventsTest.dart File client/tests/client/dom/EventsTest.dart (right): https://chromiumcodereview.appspot.com/10222026/diff/1/client/tests/client/dom/EventsTest.dart#newcode58 client/tests/client/dom/EventsTest.dart:58: MouseEvent event = document.$dom_createEvent('MouseEvent'); On 2012/04/26 18:47:36, antonmuhin wrote: ...
8 years, 8 months ago (2012-04-26 19:32:45 UTC) #3
podivilov
PTAL. http://codereview.chromium.org/10222026/diff/1/client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart File client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart (right): http://codereview.chromium.org/10222026/diff/1/client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart#newcode20 client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart:20: canvas.attributes['width'] = '$width'; On 2012/04/26 18:47:36, antonmuhin wrote: ...
8 years, 8 months ago (2012-04-27 11:59:47 UTC) #4
Anton Muhin
8 years, 8 months ago (2012-04-27 12:06:33 UTC) #5 
LGTM

http://codereview.chromium.org/10222026/diff/10001/tests/dom/canvas_test.dart
File tests/dom/canvas_test.dart (right):

http://codereview.chromium.org/10222026/diff/10001/tests/dom/canvas_test.dart...
tests/dom/canvas_test.dart:13: canvas.attributes['width'] = '$width';
do you need to stringify those?

http://codereview.chromium.org/10222026/diff/10001/tests/dom/canvas_using_htm...
File tests/dom/canvas_using_html_test.dart (right):

http://codereview.chromium.org/10222026/diff/10001/tests/dom/canvas_using_htm...
tests/dom/canvas_using_html_test.dart:14: canvas.attributes['width'] = '100';
ditto

http://codereview.chromium.org/10222026/diff/10001/tests/dom/instance_of_test...
File tests/dom/instance_of_test.dart (right):

http://codereview.chromium.org/10222026/diff/10001/tests/dom/instance_of_test...
tests/dom/instance_of_test.dart:10: canvas.attributes['width'] = '100';
ditto

http://codereview.chromium.org/10222026/diff/10001/tests/dom/wrapper_test.dart
File tests/dom/wrapper_test.dart (right):

http://codereview.chromium.org/10222026/diff/10001/tests/dom/wrapper_test.dar...
tests/dom/wrapper_test.dart:12: canvas.attributes['width'] = '100';
ditto

Powered by Google App Engine
This is Rietveld 408576698