Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10222022: Disable pub/pub_test on the vm, it is failing when running from the top level directory. (Closed)

Created:
8 years, 8 months ago by ricow1
Modified:
8 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Disable pub/pub_test on the vm, it is failing when running from the top level directory. Bug here: dartbug.com/2740 Committed: https://code.google.com/p/dart/source/detail?r=7012

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M utils/tests/pub/pub.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ricow1
8 years, 8 months ago (2012-04-26 11:54:40 UTC) #1
Mads Ager (google)
https://chromiumcodereview.appspot.com/10222022/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/10222022/diff/1/tests/standalone/standalone.status#newcode21 tests/standalone/standalone.status:21: pub/pub_test You need to add the actual expectation. pub/pub_test: ...
8 years, 8 months ago (2012-04-26 11:56:10 UTC) #2
ricow1
https://chromiumcodereview.appspot.com/10222022/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/10222022/diff/1/tests/standalone/standalone.status#newcode21 tests/standalone/standalone.status:21: pub/pub_test On 2012/04/26 11:56:10, Mads Ager wrote: > You ...
8 years, 8 months ago (2012-04-26 11:59:19 UTC) #3
Mads Ager (google)
lgtm
8 years, 8 months ago (2012-04-26 12:04:13 UTC) #4
Mads Ager (google)
8 years, 8 months ago (2012-04-26 12:04:38 UTC) #5
Mads Ager (google)
Oh, sorry, this is in the wrong status file. There is a status file in ...
8 years, 8 months ago (2012-04-26 12:10:27 UTC) #6
ricow1
Moved to right status file
8 years, 8 months ago (2012-04-26 12:15:04 UTC) #7
Mads Ager (google)
8 years, 8 months ago (2012-04-26 12:15:42 UTC) #8
Thanks, LGTM

Powered by Google App Engine
This is Rietveld 408576698