Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 10222013: (second try) unittest steps 3, 4: removes TestFramework.dart (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

(second try) unittest steps 3, 4: removes TestFramework.dart Committed: https://code.google.com/p/dart/source/detail?r=6980

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+727 lines, -1387 lines) Patch
M lib/unittest/config.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M lib/unittest/dom_config.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M lib/unittest/html_config.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M lib/unittest/html_enhanced_config.dart View 3 chunks +19 lines, -10 lines 0 comments Download
M lib/unittest/html_print.dart View 2 chunks +18 lines, -9 lines 0 comments Download
M lib/unittest/unittest.dart View 1 12 chunks +176 lines, -71 lines 0 comments Download
M lib/unittest/vm_config.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M samples/tests/samples/src/proxy/MintMakerFullyIsolated_generatedTest.dart View 2 chunks +21 lines, -29 lines 0 comments Download
M samples/tests/samples/src/proxy/MintMakerFullyIsolated_testSource.dart View 2 chunks +20 lines, -22 lines 0 comments Download
M samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_generatedTest.dart View 2 chunks +26 lines, -34 lines 0 comments Download
M samples/tests/samples/src/proxy/MintMakerPromiseWithStubs_testSource.dart View 3 chunks +22 lines, -29 lines 0 comments Download
M samples/tests/samples/src/proxy/MintMakerRpcTest.dart View 1 chunk +3 lines, -1 line 0 comments Download
M samples/tests/samples/src/proxy/PromiseBasedTest.dart View 2 chunks +41 lines, -45 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +8 lines, -12 lines 0 comments Download
M tests/isolate/isolate-leg.status View 1 chunk +3 lines, -6 lines 0 comments Download
D tests/isolate/src/APIv2_spawnBrowserNegativeTest.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/isolate/src/APIv2_spawnBrowserTest.dart View 1 chunk +0 lines, -29 lines 0 comments Download
A + tests/isolate/src/APIv2_spawnFunctionNegativeTest.dart View 1 chunk +5 lines, -9 lines 0 comments Download
A + tests/isolate/src/APIv2_spawnFunctionTest.dart View 1 chunk +4 lines, -8 lines 0 comments Download
D tests/isolate/src/APIv2_spawnStandaloneNegativeTest.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/isolate/src/APIv2_spawnStandaloneTest.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/isolate/src/APIv2_spawnUriBrowserNegativeTest.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/isolate/src/APIv2_spawnUriBrowserTest.dart View 1 chunk +0 lines, -29 lines 0 comments Download
A + tests/isolate/src/APIv2_spawnUriNegativeTest.dart View 1 chunk +3 lines, -7 lines 0 comments Download
A + tests/isolate/src/APIv2_spawnUriTest.dart View 1 chunk +3 lines, -7 lines 0 comments Download
D tests/isolate/src/APIv2_unresolvedPortsBrowserNegativeTest.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/isolate/src/APIv2_unresolvedPortsBrowserTest.dart View 1 chunk +0 lines, -53 lines 0 comments Download
A + tests/isolate/src/APIv2_unresolvedPortsNegativeTest.dart View 2 chunks +4 lines, -11 lines 0 comments Download
D tests/isolate/src/APIv2_unresolvedPortsStandaloneNegativeTest.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/isolate/src/APIv2_unresolvedPortsStandaloneTest.dart View 1 chunk +0 lines, -50 lines 0 comments Download
A + tests/isolate/src/APIv2_unresolvedPortsTest.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M tests/isolate/src/ConstructorTest.dart View 2 chunks +8 lines, -11 lines 0 comments Download
M tests/isolate/src/CountTest.dart View 2 chunks +21 lines, -27 lines 0 comments Download
M tests/isolate/src/CrossIsolateMessageTest.dart View 2 chunks +18 lines, -21 lines 0 comments Download
M tests/isolate/src/Isolate2NegativeTest.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M tests/isolate/src/Isolate3NegativeTest.dart View 2 chunks +10 lines, -12 lines 0 comments Download
M tests/isolate/src/IsolateComplexMessagesTest.dart View 2 chunks +14 lines, -18 lines 0 comments Download
M tests/isolate/src/IsolateNegativeTest.dart View 2 chunks +7 lines, -10 lines 0 comments Download
M tests/isolate/src/MandelIsolateTest.dart View 2 chunks +8 lines, -12 lines 0 comments Download
M tests/isolate/src/Message2Test.dart View 2 chunks +14 lines, -16 lines 0 comments Download
M tests/isolate/src/MessageTest.dart View 4 chunks +44 lines, -53 lines 0 comments Download
M tests/isolate/src/MintMakerTest.dart View 3 chunks +24 lines, -33 lines 0 comments Download
M tests/isolate/src/Mixed2Test.dart View 2 chunks +20 lines, -22 lines 0 comments Download
M tests/isolate/src/MixedTest.dart View 2 chunks +7 lines, -10 lines 0 comments Download
M tests/isolate/src/NestedSpawn2Test.dart View 2 chunks +13 lines, -16 lines 0 comments Download
M tests/isolate/src/NestedSpawnTest.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M tests/isolate/src/PortTest.dart View 1 chunk +48 lines, -52 lines 0 comments Download
M tests/isolate/src/RequestReplyTest.dart View 2 chunks +16 lines, -19 lines 0 comments Download
M tests/isolate/src/SpawnTest.dart View 2 chunks +8 lines, -11 lines 0 comments Download
M tests/isolate/src/StaticStateTest.dart View 2 chunks +17 lines, -20 lines 0 comments Download
D tests/isolate/src/TestFramework.dart View 1 chunk +0 lines, -277 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 2 1 chunk +7 lines, -36 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Siggi Cherem (dart-lang)
I uploaded 2 patch sets, Patch set 1 is the original CL reviewed before. Patch ...
8 years, 8 months ago (2012-04-25 20:42:45 UTC) #1
Bob Nystrom
8 years, 8 months ago (2012-04-25 22:19:44 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698