Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10221014: Reapply "Avoid "=== true" inside code by calling a function that does this for us." (Closed)

Created:
8 years, 7 months ago by floitsch
Modified:
8 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Avoid "=== true" inside code by calling a function that does this for us." This reapplies a fixed version of commit 7000. Original CL: https://chromiumcodereview.appspot.com/10140027/ Committed: https://code.google.com/p/dart/source/detail?r=7068

Patch Set 1 #

Patch Set 2 : Changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -26 lines) Patch
A frog/tests/leg/src/BoolifiedOperatorTest.dart View 1 chunk +74 lines, -0 lines 0 comments Download
M frog/tests/leg/src/ConstantFoldingTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/tests/leg/src/mock_compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 8 chunks +14 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 chunk +9 lines, -8 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 1 5 chunks +26 lines, -4 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 4 chunks +56 lines, -7 lines 0 comments Download
A tests/language/src/Operator5Test.dart View 1 chunk +61 lines, -0 lines 0 comments Download
M tests/utils/src/DummyCompilerTest.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
floitsch
8 years, 7 months ago (2012-04-27 11:19:45 UTC) #1
Turns out the self-hosting failure was due to not providing the correct
lib-files. This CL didn't cause the failure.
Applying TBR.

Note: changes to original version can be seen by comparing uploaded Patchset 1
and patchset 2. I added an assert that would have helped diagnose the problem
earlier.

Powered by Google App Engine
This is Rietveld 408576698