Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 10209016: test rename overhaul: step 2 css tests. (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, terry
Visibility:
Public.

Description

test rename overhaul: step 2 css tests. Committed: https://code.google.com/p/dart/source/detail?r=6961

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1009 lines, -1050 lines) Patch
M tools/test.dart View 3 chunks +1 line, -4 lines 0 comments Download
A utils/tests/css/declaration_tests.dart View 1 chunk +249 lines, -0 lines 2 comments Download
A utils/tests/css/expression_tests.dart View 1 chunk +524 lines, -0 lines 0 comments Download
A utils/tests/css/selector_literal_tests.dart View 1 chunk +235 lines, -0 lines 0 comments Download
D utils/tests/css/src/DeclarationTest.dart View 1 chunk +0 lines, -256 lines 0 comments Download
D utils/tests/css/src/ExpressionTest.dart View 1 chunk +0 lines, -533 lines 0 comments Download
D utils/tests/css/src/SelectorLiteralTest.dart View 1 chunk +0 lines, -242 lines 0 comments Download
D utils/tests/css/test_config.dart View 1 chunk +0 lines, -15 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-25 01:58:52 UTC) #1
Siggi Cherem (dart-lang)
(terry - this basically moves the tests one level up, and moved all tests to ...
8 years, 8 months ago (2012-04-25 01:59:28 UTC) #2
Bob Nystrom
One open question but otherwise LGTM. https://chromiumcodereview.appspot.com/10209016/diff/1/utils/tests/css/declaration_tests.dart File utils/tests/css/declaration_tests.dart (right): https://chromiumcodereview.appspot.com/10209016/diff/1/utils/tests/css/declaration_tests.dart#newcode50 utils/tests/css/declaration_tests.dart:50: Expect.isNotNull(stylesheet); Do we ...
8 years, 8 months ago (2012-04-25 18:12:49 UTC) #3
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-25 18:20:40 UTC) #4
https://chromiumcodereview.appspot.com/10209016/diff/1/utils/tests/css/declar...
File utils/tests/css/declaration_tests.dart (right):

https://chromiumcodereview.appspot.com/10209016/diff/1/utils/tests/css/declar...
utils/tests/css/declaration_tests.dart:50: Expect.isNotNull(stylesheet);
On 2012/04/25 18:12:49, Bob Nystrom wrote:
> Do we support assertions that are outside of any test() block? If not, maybe
we
> should put each of these test functions in one?

We actually do (I'm actually adding that to unittest.dart in the other CL that
we have pending), meanwhile, because this test is not importing unittest.dart,
it actually works because the current infrastructure supports it too.

Powered by Google App Engine
This is Rietveld 408576698