Issue 10207033: Make CanvasPixelArray pretent to be Uint8ClampedArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10207033: Make CanvasPixelArray pretent to be Uint8ClampedArray (Closed)

Created:
8 years, 8 months ago by sra1

Modified:
8 years, 8 months ago

Reviewers:
vsm, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make CanvasPixelArray pretent to be Uint8ClampedArray Eventually CanvasPixelArray will go away. Committed: https://code.google.com/p/dart/source/detail?r=6922

Patch Set 1 : #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -11 lines)			Patch
M	client/tests/client/client.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	client/tests/client/client-leg.status	View	1 chunk	+4 lines, -10 lines	0 comments	Download
A	client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart	View	1 chunk	+62 lines, -0 lines	1 comment	Download
A	client/tests/client/html/CanvasPixelArrayTypeAliasTest.dart	View	1 chunk	+62 lines, -0 lines	0 comments	Download
M	frog/corejs.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/native_helper.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

https://chromiumcodereview.appspot.com/10207033/diff/4001/client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart File client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart (right): https://chromiumcodereview.appspot.com/10207033/diff/4001/client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart#newcode44 client/tests/client/dom/CanvasPixelArrayTypeAliasTest.dart:44: test('PutImageData', () { Isn't this one redundant with the ...

8 years, 8 months ago (2012-04-25 05:38:18 UTC) #2

LGTM.

Expand Messages | Collapse Messages