Generate DartDOMStringList binding.

Generate DartDOMStringList binding.


R=antonm@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=6950

[Anton Muhin, 2012-04-24 18:28:03]

Will it make DOMStringList inherit from List<String>?

https://chromiumcodereview.appspot.com/10207019/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10207019/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:645: 'DOMStringList': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
I don't know if we ready to implement something like that, but technically I
would expect DOMStringList to extends List<String> interface, but be a separate
interface and implementation on its own.  The unpleasant part is we should
ideally accept List<String> as input argument---once again I hate IDLs---they
should distinguish those cases.

Maybe we should provide such overrides in our supplementals, wdyt?

Or make generator uglier and allow more generic types as arguments, wdyt?

[podivilov, 2012-04-24 18:47:31]

https://chromiumcodereview.appspot.com/10207019/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10207019/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:645: 'DOMStringList': IDLTypeInfo('DOMStringList',
dart_type='List<String>', custom_to_native=True),
On 2012/04/24 18:28:03, antonmuhin wrote:
> I don't know if we ready to implement something like that, but technically I
> would expect DOMStringList to extends List<String> interface, but be a
separate
> interface and implementation on its own. 
I'm piggybacking on sequences support that we have in our generator. See
dart.idl for the list of classes that currently implement List<T>.

> The unpleasant part is we should
> ideally accept List<String> as input argument---once again I hate IDLs---they
> should distinguish those cases.
> 
> Maybe we should provide such overrides in our supplementals, wdyt?
> 
> Or make generator uglier and allow more generic types as arguments, wdyt?

I think List<String> as input argument should work as we have custom toNative.
Am I missing something?

[Anton Muhin, 2012-04-24 18:48:17]

I'd like it to work in checked mode as well

[Anton Muhin, 2012-04-24 18:58:06]

LGTM