Issue 10207010: Make dart2js work on Windows.

Issue 10207010: Make dart2js work on Windows. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make dart2js work on Windows. Committed: https://code.google.com/p/dart/source/detail?r=6889

Patch Set 2 : Address review comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -122 lines)			Patch
M	dart/frog/frog_leg.dart	View		2 chunks	+2 lines, -37 lines	0 comments	Download
M	dart/lib/compiler/implementation/dart2js.dart	View		5 chunks	+10 lines, -42 lines	0 comments	Download
M	dart/lib/compiler/implementation/filenames.dart	View		3 chunks	+10 lines, -0 lines	0 comments	Download
A	dart/lib/compiler/implementation/util/uri_extras.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download
M	dart/utils/compiler/build_helper.dart	View		3 chunks	+56 lines, -40 lines	0 comments	Download
M	dart/utils/compiler/compiler.gyp	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/lib/compiler/implementation/util/uri_extras.dart File dart/lib/compiler/implementation/util/uri_extras.dart (right): https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/lib/compiler/implementation/util/uri_extras.dart#newcode9 dart/lib/compiler/implementation/util/uri_extras.dart:9: String relativize(Uri base, Uri uri) { Why isn't ...

8 years, 8 months ago (2012-04-24 14:29:46 UTC) #2

ahe

8 years, 8 months ago (2012-04-24 14:55:34 UTC) #3

Hi Nicolas,

Thank you for your comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/util/uri_extras.dart (right):

https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/util/uri_extras.dart:9: String relativize(Uri
base, Uri uri) {
On 2012/04/24 14:29:46, ngeoffray wrote:
> Why isn't that method in uri instead?

I'm not sure if it belongs there.

https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/utils/compiler...
File dart/utils/compiler/compiler.gyp (right):

https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/utils/compiler...
dart/utils/compiler/compiler.gyp:32: #
'<(PRODUCT_DIR)<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)'.
On 2012/04/24 14:29:46, ngeoffray wrote:
> Should there be a '/' after PRODUCT_DIR?

Done.

https://chromiumcodereview.appspot.com/10207010/diff/2001/dart/utils/compiler...
dart/utils/compiler/compiler.gyp:34: # GYP so it doesn't work.
On 2012/04/24 14:29:46, ngeoffray wrote:
> GYP and paths on windows?

Nope. The argument simply disappears, at least on Mac.

Expand Messages | Collapse Messages