Issue 10205015: Add some documentation to the parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10205015: Add some documentation to the parser. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, compiler-dev_dartlang.org, Ivan Posva, lukechurch, gbracha

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add some documentation to the parser. Committed: https://code.google.com/p/dart/source/detail?r=6884

Patch Set 2 : Address review comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	dart/lib/compiler/implementation/scanner/listener.dart	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
	M	dart/lib/compiler/implementation/scanner/parser.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10205015/diff/1/dart/lib/compiler/implementation/scanner/listener.dart File dart/lib/compiler/implementation/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/10205015/diff/1/dart/lib/compiler/implementation/scanner/listener.dart#newcode498 dart/lib/compiler/implementation/scanner/listener.dart:498: * builds elements representing the top-level declaration found ...

8 years, 8 months ago (2012-04-24 14:25:31 UTC) #2

ahe

8 years, 8 months ago (2012-04-24 14:50:49 UTC) #3

Thanks, Nicolas.

https://chromiumcodereview.appspot.com/10205015/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/listener.dart (right):

https://chromiumcodereview.appspot.com/10205015/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/listener.dart:498: * builds elements
representing the top-level declaration found in the
On 2012/04/24 14:25:31, ngeoffray wrote:
> delcaration -> declarations?

Done.

Expand Messages | Collapse Messages

Issue 10205015: Add some documentation to the parser. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments #

Messages