Issue 10205006: Mark types as instantiated or uninstantiated upon finalization.

Issue 10205006: Mark types as instantiated or uninstantiated upon finalization. (Closed)

Created:
8 years, 8 months ago by regis

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark types as instantiated or uninstantiated upon finalization. Committed: https://code.google.com/p/dart/source/detail?r=6894

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -23 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	8 chunks	+28 lines, -15 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10205006/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/10205006/diff/1/runtime/vm/object.cc#newcode2375 runtime/vm/object.cc:2375: const AbstractTypeArguments& args = Can IsInstantiated be true ...

8 years, 8 months ago (2012-04-24 00:56:28 UTC) #2

regis

8 years, 8 months ago (2012-04-24 16:06:58 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/10205006/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10205006/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:2375: const AbstractTypeArguments& args =
On 2012/04/24 00:56:28, srdjan wrote:
> Can IsInstantiated be true if the type is not finalized?

Yes. We call IsInstantiated() on a type before marking it as
kFinalizedInstantiated or kFinalizedUninstantiated.

https://chromiumcodereview.appspot.com/10205006/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/10205006/diff/1/runtime/vm/object.h#ne...
runtime/vm/object.h:982: return raw_ptr()->type_state_ ==
RawTypeParameter::kFinalizedUninstantiated;
On 2012/04/24 00:56:28, srdjan wrote:
> Assert somewhere that is is not kFinalizedInstantiated?

Done.

Expand Messages | Collapse Messages