Issue 10202018: Fix bug http://code.google.com/p/dart/issues/detail?id=2718: methods that are implemented by the ht…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10202018: Fix bug http://code.google.com/p/dart/issues/detail?id=2718: methods that are implemented by the ht… (Closed)

Created:
8 years, 8 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, sra1, karlklose, ahe, Lasse Reichstein Nielsen, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug http://code.google.com/p/dart/issues/detail?id=2718: methods that are implemented by the html/dom library should be called with dart2js calling conventions. Committed: https://code.google.com/p/dart/source/detail?r=7020

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
M	client/tests/client/client-leg.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/native_emitter.dart	View	1	2 chunks	+15 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10202018/diff/1/lib/compiler/implementation/native_emitter.dart File lib/compiler/implementation/native_emitter.dart (right): https://chromiumcodereview.appspot.com/10202018/diff/1/lib/compiler/implementation/native_emitter.dart#newcode188 lib/compiler/implementation/native_emitter.dart:188: // Calling a method that the library implements, ...

8 years, 8 months ago (2012-04-26 15:02:29 UTC) #2

ngeoffray

8 years, 8 months ago (2012-04-26 15:07:13 UTC) #3

Thanks Kasper.

https://chromiumcodereview.appspot.com/10202018/diff/1/lib/compiler/implement...
File lib/compiler/implementation/native_emitter.dart (right):

https://chromiumcodereview.appspot.com/10202018/diff/1/lib/compiler/implement...
lib/compiler/implementation/native_emitter.dart:188: // Calling a method that
the library implements, we call it
On 2012/04/26 15:02:29, kasperl wrote:
> Calling -> When calling.
> 
> What does 'that the library implements' mean? Does it mean that it has a
native
> implementation in the Dart source code? I guess so.

Yes, I will add that as a comment.

Expand Messages | Collapse Messages

Issue 10202018: Fix bug http://code.google.com/p/dart/issues/detail?id=2718: methods that are implemented by the ht… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages