Issue 10200005: Issue 2693. Don't add null imports

Issue 10200005: Issue 2693. Don't add null imports (Closed)

Created:
8 years, 8 months ago by scheglov

Modified:
8 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 2693. Don't add null imports http://code.google.com/p/dart/issues/detail?id=2693 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6866

Patch Set 2 : Tweaks for review comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -34 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/LibraryUnit.java	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java	View	1	3 chunks	+17 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10200005/diff/1/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java File compiler/java/com/google/dart/compiler/ast/LibraryUnit.java (right): https://chromiumcodereview.appspot.com/10200005/diff/1/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java#newcode1 compiler/java/com/google/dart/compiler/ast/LibraryUnit.java:1: // Copyright (c) 2011, the Dart project authors. ...

8 years, 8 months ago (2012-04-23 23:21:03 UTC) #2

scheglov

8 years, 8 months ago (2012-04-24 00:18:34 UTC) #3

https://chromiumcodereview.appspot.com/10200005/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/LibraryUnit.java (right):

https://chromiumcodereview.appspot.com/10200005/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/LibraryUnit.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
On 2012/04/23 23:21:03, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10200005/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java
(right):

https://chromiumcodereview.appspot.com/10200005/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java:1:
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
On 2012/04/23 23:21:03, Brian Wilkerson wrote:
> nit: copyright year

Done.

Expand Messages | Collapse Messages