Issue 10198033: Add more subtype checks, and repeat them so that any inlined checks can be tested as well (first te…

Issue 10198033: Add more subtype checks, and repeat them so that any inlined checks can be tested as well (first te… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add more subtype checks, and repeat them so that any inlined checks can be tested as well (first test always goes to runtime). Committed: https://code.google.com/p/dart/source/detail?r=7040

Patch Set 1 #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -5 lines)			Patch
M	tests/language/language-leg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/src/GenericInstanceof2Test.dart	View	2 chunks	+9 lines, -1 line	2 comments	Download
A	tests/language/src/GenericInstanceof3Test.dart	View	1 chunk	+59 lines, -0 lines	1 comment	Download
M	tests/language/src/GenericInstanceofTest.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/language/src/Instanceof2Test.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/language/src/Instanceof3Test.dart	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	tests/language/src/InstanceofTest.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10198033/diff/1/tests/language/src/GenericInstanceof2Test.dart File tests/language/src/GenericInstanceof2Test.dart (right): https://chromiumcodereview.appspot.com/10198033/diff/1/tests/language/src/GenericInstanceof2Test.dart#newcode62 tests/language/src/GenericInstanceof2Test.dart:62: // Repeat type checks so that inlined tests ...

8 years, 8 months ago (2012-04-26 19:02:49 UTC) #2

srdjan

8 years, 8 months ago (2012-04-26 19:53:17 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10198033/diff/1/tests/language/src/Gen...
File tests/language/src/GenericInstanceof2Test.dart (right):

https://chromiumcodereview.appspot.com/10198033/diff/1/tests/language/src/Gen...
tests/language/src/GenericInstanceof2Test.dart:62: // Repeat type checks so that
inlined tests can be tested as well.
On 2012/04/26 19:02:49, regis wrote:
> Why not just
> testAll();
> testAll();
> ?

Discussed, leaving it to 5 for future multi-stage checks.

Expand Messages | Collapse Messages