Issue 10198028: Remove some more uses of named temporaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10198028: Remove some more uses of named temporaries. (Closed)

Created:
8 years, 8 months ago by Kevin Millikin (Google)

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove some more uses of named temporaries. Remove all uses of TempVal except those used in expressions with control flow (&&, ||, and ?:). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=7144

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -85 lines)			Patch
	M	runtime/vm/flow_graph_builder.h	View		2 chunks	+3 lines, -8 lines	0 comments	Download
	M	runtime/vm/flow_graph_builder.cc	View		8 chunks	+100 lines, -77 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Google)

As far as I can see, the only uses of TempVal remaining are in ?:, ...

8 years, 8 months ago (2012-04-26 12:33:05 UTC) #1

LGTM