- Add tests/lib to start testing libraries outside of core.

- Add tests/lib to start testing libraries outside of core.
Committed: https://code.google.com/p/dart/source/detail?r=6929

[Mads Ager (google), 2012-04-24 18:04:35]

LGTM

We should investigate whether the library works when compiled to JavaScript. If
it doesn't, maybe we should file a bug on that. It seems to me that it should
work?

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status#n...
tests/lib/lib.status:6: [ $compiler == dartc || $compiler == frog || $compiler
== dart2js]
This really shouldn't be neccesary, right? In principle, the Dart code should
work fine when translated to JavaScript since everything is operating on 32-bit
integers.

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/src/crypto/s...
File tests/lib/src/crypto/sha1Test.dart (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/src/crypto/s...
tests/lib/src/crypto/sha1Test.dart:537:
"11bca5b61fc1f6d59078ec5354bc6d9adecc0c5d",
Maybe remove the final ',' and move the closing bracket to the end of the last
line?

[Ivan Posva, 2012-04-25 09:14:01]

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status#n...
tests/lib/lib.status:6: [ $compiler == dartc || $compiler == frog || $compiler
== dart2js]
On 2012/04/24 18:04:35, Mads Ager wrote:
> This really shouldn't be neccesary, right? In principle, the Dart code should
> work fine when translated to JavaScript since everything is operating on
32-bit
> integers.

It should not be necessary, but a quick test did not succeed, so I disabled them
to get this in while avoiding a red bot.

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/src/crypto/s...
File tests/lib/src/crypto/sha1Test.dart (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/src/crypto/s...
tests/lib/src/crypto/sha1Test.dart:537:
"11bca5b61fc1f6d59078ec5354bc6d9adecc0c5d",
On 2012/04/24 18:04:35, Mads Ager wrote:
> Maybe remove the final ',' and move the closing bracket to the end of the last
> line?
The final was a conscious decision, I will also make the array const so that the
test cannot change the expected results while running.

The values were created using an external program, which is why the opening and
closing brackets are on their own lines to make the contents pasteable.

[Mads Ager (google), 2012-04-25 09:31:13]

Still LGTM

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status#n...
tests/lib/lib.status:6: [ $compiler == dartc || $compiler == frog || $compiler
== dart2js]
On 2012/04/25 09:14:01, Ivan Posva wrote:
> On 2012/04/24 18:04:35, Mads Ager wrote:
> > This really shouldn't be neccesary, right? In principle, the Dart code
should
> > work fine when translated to JavaScript since everything is operating on
> 32-bit
> > integers.
> 
> It should not be necessary, but a quick test did not succeed, so I disabled
them
> to get this in while avoiding a red bot.

OK, let's file a bug and we should see if we can make it work when compiled to
JS as well.

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/src/crypto/s...
File tests/lib/src/crypto/sha1Test.dart (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/src/crypto/s...
tests/lib/src/crypto/sha1Test.dart:537:
"11bca5b61fc1f6d59078ec5354bc6d9adecc0c5d",
On 2012/04/25 09:14:01, Ivan Posva wrote:
> On 2012/04/24 18:04:35, Mads Ager wrote:
> > Maybe remove the final ',' and move the closing bracket to the end of the
last
> > line?
> The final was a conscious decision, I will also make the array const so that
the
> test cannot change the expected results while running.
> 
> The values were created using an external program, which is why the opening
and
> closing brackets are on their own lines to make the contents pasteable.

I would still prefer to end this with:

  "...c5d" ];

instead of

  "...c56",
];

[Bill Hesse, 2012-04-25 10:19:35]

Oops - my comments were stuck in Draft mode - I never sent them.

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tests/lib/lib.status#n...
tests/lib/lib.status:3: # BSD-style license that can be found in the LICENSE
file.
Tests are now supposed to end in _tests.dart, if they follow the standard that
creates them with StandardTestSuite.forDirectory(dir).  Consider doing this, and
the change in test.dart.

https://chromiumcodereview.appspot.com/10197008/diff/1/tools/test.dart
File tools/test.dart (right):

https://chromiumcodereview.appspot.com/10197008/diff/1/tools/test.dart#newcode61
tools/test.dart:61: ];
Can you add the directory tests/lib here, to TEST_SUITE_DIRECTORIES?  This is
the new, easy way to add a StandardTestSuite.