Issue 10196003: Dart_IsSame -> Dart_IdentityEquals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10196003: Dart_IsSame -> Dart_IdentityEquals. (Closed)

Created:
8 years, 8 months ago by turnidge

Modified:
8 years, 7 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Dart_IsSame -> Dart_IdentityEquals. Use return value for the equality result. Made function more efficient by avoiding a DARTSCOPE. Committed: https://code.google.com/p/dart/source/detail?r=7664

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -48 lines)			Patch
M	include/dart_api.h	View	1	1 chunk	+4 lines, -9 lines	0 comments	Download
M	vm/dart_api_impl.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View		6 chunks	+12 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 8 months ago (2012-04-24 11:03:52 UTC) #2

LGTM and thanks.

I'll prepare a change on bindings side today and send it to you so we can
coordinate landing.  Or you may keep an old API for a couple of days, up to you.

Expand Messages | Collapse Messages