test renaming overhaul: step 4 client tests

test renaming overhaul: step 4 client tests

Committed: https://code.google.com/p/dart/source/detail?r=7041

[Siggi Cherem (dart-lang), 2012-04-26 01:32:08]

This change:
- moves client tests to the top-level test directory:
  client/tests/client/{dom,html,json,smoke}
    => tests/{dom,html,json,benckmark_smoke}

- adds these tests as 4 suites in test.dart
- renames files to use the lower_case_file_convention
- fixes document_test because it uses it's file name in the test
- updates buildbot_annotated_steps and presubmit scripts.

[Emily Fortuna, 2012-04-26 16:00:51]

lgtm. Just a few comments.

https://chromiumcodereview.appspot.com/10191033/diff/172/client/tests/dartc/d...
File client/tests/dartc/dartc.status (left):

https://chromiumcodereview.appspot.com/10191033/diff/172/client/tests/dartc/d...
client/tests/dartc/dartc.status:12: tests/client/dom: Skip                  #
These have known type errors.
Add benchmark_smoke, dom, html to the status file?

https://chromiumcodereview.appspot.com/10191033/diff/172/tests/html/html_test...
File tests/html/html_test.dart (right):

https://chromiumcodereview.appspot.com/10191033/diff/172/tests/html/html_test...
tests/html/html_test.dart:12: #source('css_style_declaration_tests.dart');
Vijay has a CL to break this test into separate pieces so we're not testing so
many things in one test. I guess it hasn't landed yet?

[Siggi Cherem (dart-lang), 2012-04-26 18:07:50]

All set - I merged in Vijay's changes. Also changed the names of a few tests to
include the suggestion from Stephen and Anton that we use htmlelement_test
rather than html_element_test.

https://chromiumcodereview.appspot.com/10191033/diff/172/client/tests/dartc/d...
File client/tests/dartc/dartc.status (left):

https://chromiumcodereview.appspot.com/10191033/diff/172/client/tests/dartc/d...
client/tests/dartc/dartc.status:12: tests/client/dom: Skip                  #
These have known type errors.
On 2012/04/26 16:00:51, Emily Fortuna wrote:
> Add benchmark_smoke, dom, html to the status file?

This code was running only on subdirectories of client/, so we don't need to
explicitly skip them here.

https://chromiumcodereview.appspot.com/10191033/diff/172/tests/html/html_test...
File tests/html/html_test.dart (right):

https://chromiumcodereview.appspot.com/10191033/diff/172/tests/html/html_test...
tests/html/html_test.dart:12: #source('css_style_declaration_tests.dart');
On 2012/04/26 16:00:51, Emily Fortuna wrote:
> Vijay has a CL to break this test into separate pieces so we're not testing so
> many things in one test. I guess it hasn't landed yet?

Done.

[Bob Nystrom, 2012-04-26 18:22:45]

LGTM!